Set showExpandedEvents in change streams for server v6+.
#54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdq45gj
reviewed
Nov 25, 2024
|
|
||
| suite.Require().NoError(verifier.WritesOff(ctx)) | ||
|
|
||
| err = verifierRunner.Await() |
Collaborator
There was a problem hiding this comment.
I don't think a change stream error will be returned until writesOff
Collaborator
Author
There was a problem hiding this comment.
It’s actually indeterminate, it seems: the error may happen before writesOff, or it may happen when shutting down the change stream.
FGasper
force-pushed
the
felipe_expanded_events
branch
from
0f43765 to
f3a9b91
Compare
FGasper
force-pushed
the
felipe_expanded_events
branch
from
58ca577 to
d1dff2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since migration-verifier forbids DDL events during verification, it should set
showExpandedEventsso that it can fail on events likecreateorshardCollection.For convenience, this copies mslices.Of() from mongosync.